From 4843c7160662835c38c7993546aa04691ae3d26a Mon Sep 17 00:00:00 2001 From: Daniel Akulenok Date: Thu, 29 Jan 2026 20:55:26 +0100 Subject: [PATCH] feat: show detailed changes with --diff flag - Display specific record changes when --diff flag is used - Add 'or self.module._diff' condition to all change logging - Shows Added, Removed, Changed records with --diff (same as -v) - Skipped records still only shown with -vv - Provides detailed diff output without requiring -v flag - Users can now see what changed with just --diff flag --- plugins/modules/nsupdate_zone.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/plugins/modules/nsupdate_zone.py b/plugins/modules/nsupdate_zone.py index 1b6d2ac..61c26c0 100644 --- a/plugins/modules/nsupdate_zone.py +++ b/plugins/modules/nsupdate_zone.py @@ -643,14 +643,14 @@ class DNSZoneManager: 'type': desired['type'], 'values': desired['values'] }) - if self.module._verbosity >= 1: + if self.module._verbosity >= 1 or self.module._diff: self.display.vvv(f"[{self.zone_name_str}] Removed: {name_str} {record_type}") else: # State is 'present' if key not in current_records: # Record doesn't exist - add it changes['adds'].append(desired) - if self.module._verbosity >= 1: + if self.module._verbosity >= 1 or self.module._diff: values_str = ', '.join(str(v) for v in desired['values']) self.display.vvv(f"[{self.zone_name_str}] Added: {name_str} {record_type} {values_str}") else: @@ -658,7 +658,7 @@ class DNSZoneManager: current = current_records[key] if desired['values'] != current['values'] or desired['ttl'] != current['ttl']: changes['updates'].append(desired) - if self.module._verbosity >= 1: + if self.module._verbosity >= 1 or self.module._diff: before_values = ', '.join(str(v) for v in current['values']) after_values = ', '.join(str(v) for v in desired['values']) self.display.vvv(f"[{self.zone_name_str}] Changed: {name_str} {record_type} ({before_values} -> {after_values})") @@ -679,7 +679,7 @@ class DNSZoneManager: 'type': current['type'], 'values': current['values'] }) - if self.module._verbosity >= 1: + if self.module._verbosity >= 1 or self.module._diff: self.display.vvv(f"[{self.zone_name_str}] Removed: {name_str} {record_type}") return changes