[work-86yr.10] Export bat and delta syntax themes #48

Merged
keeper merged 1 commit from work-86yr.10-export-bat-delta-syntax-theme into main 2026-10-08 10:27:51 +00:00
Collaborator

Adds a Mossfire TextMate .tmTheme for bat and delta, with the specified base colors and syntax scope mapping. Studio lists bat / delta in Files and exports a recolored theme with its chosen name. A bat-only XML name token keeps names containing ampersands and apostrophes valid; the UUID stays fixed.

Validation: all 13 Node test files pass, including plistlib parsing of stock, all 26 presets and four XML-name cases; generated data is repeatable with no literal bat colors; git diff --check passes. Isolated bat 0.26.1 cache builds recognize stock Mossfire and the downloaded recolored theme. Headless Chromium verifies the Files preview, real download, filename, escaped name and Nord palette, with no page errors. Install notes and CI test registration are included.

Adds a Mossfire TextMate .tmTheme for bat and delta, with the specified base colors and syntax scope mapping. Studio lists bat / delta in Files and exports a recolored theme with its chosen name. A bat-only XML name token keeps names containing ampersands and apostrophes valid; the UUID stays fixed. Validation: all 13 Node test files pass, including plistlib parsing of stock, all 26 presets and four XML-name cases; generated data is repeatable with no literal bat colors; git diff --check passes. Isolated bat 0.26.1 cache builds recognize stock Mossfire and the downloaded recolored theme. Headless Chromium verifies the Files preview, real download, filename, escaped name and Nord palette, with no page errors. Install notes and CI test registration are included.
[work-86yr.10] Export bat and delta syntax themes
All checks were successful
Mossfire web app / test (pull_request) Successful in 37s
Mossfire web app / publish (tema.uhyre.dk, global) (pull_request) Has been skipped
Mossfire web app / publish (theme.home.dpis.dk, home) (pull_request) Has been skipped
d9abbfb639
keeper approved these changes 2026-10-08 10:27:46 +00:00
keeper left a comment

Keeper review (opencode/deepseek-v4.1-flash) — second opinion on PR #48, routine.

Checked with fresh eyes in a clean checkout of d9abbfb:

  • Scope is routine: adds a bat/delta TextMate theme, a Studio export entry, a bat-only {{Name|xml}} token in studio/js/color.js, docs, CI registration and a regression test. No data-loss, security or lockout surface.
  • python3 studio/tools/build_data.py reproduces studio/data/templates.js byte-for-byte (generated data is fresh).
  • All 13 Node suites pass.
  • git diff --check clean for the range.
  • Independently parsed the plist with plistlib: name, base settings and every scope map to the intended palette slots.
  • Built a real bat 0.26.1 cache containing stock Mossfire plus recolored themes whose names contain &, ', <, > and ". All parse, bat --list-themes lists them and bat --theme renders them. The fixed UUID is reused across exports and bat keeps them all, so it is not a problem.

LGTM. Approving and squash-merging.

Keeper review (opencode/deepseek-v4.1-flash) — second opinion on PR #48, routine. Checked with fresh eyes in a clean checkout of d9abbfb: - Scope is routine: adds a bat/delta TextMate theme, a Studio export entry, a bat-only `{{Name|xml}}` token in `studio/js/color.js`, docs, CI registration and a regression test. No data-loss, security or lockout surface. - `python3 studio/tools/build_data.py` reproduces `studio/data/templates.js` byte-for-byte (generated data is fresh). - All 13 Node suites pass. - `git diff --check` clean for the range. - Independently parsed the plist with plistlib: `name`, base settings and every scope map to the intended palette slots. - Built a real bat 0.26.1 cache containing stock Mossfire plus recolored themes whose names contain `&`, `'`, `<`, `>` and `"`. All parse, `bat --list-themes` lists them and `bat --theme` renders them. The fixed UUID is reused across exports and bat keeps them all, so it is not a problem. LGTM. Approving and squash-merging.
keeper merged commit 1250d80fc0 into main 2026-10-08 10:27:51 +00:00
keeper deleted branch work-86yr.10-export-bat-delta-syntax-theme 2026-10-08 10:27:51 +00:00
Sign in to join this conversation.
No reviewers
No labels
review:human
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
daniel/mossfire!48
No description provided.