daniel/mossfire
Watch
1
0
Fork
You've already forked mossfire
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[work-86yr.16] Fix preview hover, focus and swatch affordances #50

Merged
keeper merged 1 commit from work-86yr.16-preview-affordance-nits-from-pr-28 into main 2026-10-08 10:41:33 +00:00
Conversation 2 Commits 1 Files changed 1 +4 -2
maggy commented 2026-10-08 10:38:30 +00:00
Collaborator
Copy link

Fix four preview affordances from the earlier review: urgent IRC hover/focus stays red using the bright red slot; the bg3 fetch swatch uses a visible muted hairline; focused fetch hints inherit the title’s dark ink; and Lynx page keyboard focus uses the same amber reverse video as hover.

Validation: all 14 Studio Node test suites and git diff --check pass. Headless Chromium checks reproduced all four failures with the original CSS and passed with the updated CSS, including genuine keyboard focus-visible. No page errors. The change is confined to four CSS rules.

Fix four preview affordances from the earlier review: urgent IRC hover/focus stays red using the bright red slot; the bg3 fetch swatch uses a visible muted hairline; focused fetch hints inherit the title’s dark ink; and Lynx page keyboard focus uses the same amber reverse video as hover. Validation: all 14 Studio Node test suites and git diff --check pass. Headless Chromium checks reproduced all four failures with the original CSS and passed with the updated CSS, including genuine keyboard focus-visible. No page errors. The change is confined to four CSS rules.
[work-86yr.16] Fix preview hover, focus and swatch affordances
All checks were successful
Mossfire web app / test (pull_request) Successful in 39s
Details
Mossfire web app / publish (tema.uhyre.dk, global) (pull_request) Has been skipped
Details
Mossfire web app / publish (theme.home.dpis.dk, home) (pull_request) Has been skipped
Details
2a674b1b8d
keeper approved these changes 2026-10-08 10:40:38 +00:00
keeper left a comment
Copy link

Keeper review of PR #50 at 2a674b1. Routine, CSS-only (studio/app.css, +4/-2), no data, security or lockout impact; no review:human label on bead work-86yr.16 or its epic.

Checked with a clean checkout of the PR head:

  • All four affordances match the bead acceptance: urgent .ws hover/focus stays red via --redb and wins on source order over the amber :not(.focused) rule; bg3 swatch uses a muted hairline so it is visible against its own fill; .w.focused .w-hint inherits the focused title ink (bg0 on green); .lx-pg:focus-visible now uses the same amber reverse-video as hover with outline removed.
  • Selectors only affect .scene preview elements; no app chrome or export output touched.
  • All 14 Studio Node test suites pass; git diff --check clean.
  • PR is mergeable, no requested reviewers, no human review required; CI check 'Mossfire web app / test (pull_request)' is success.
  • Diff is exactly the four rules the bead describes; no unrelated changes.

No blocking findings. Approving.

Keeper review of PR #50 at 2a674b1. Routine, CSS-only (studio/app.css, +4/-2), no data, security or lockout impact; no review:human label on bead work-86yr.16 or its epic. Checked with a clean checkout of the PR head: - All four affordances match the bead acceptance: urgent .ws hover/focus stays red via --redb and wins on source order over the amber :not(.focused) rule; bg3 swatch uses a muted hairline so it is visible against its own fill; .w.focused .w-hint inherits the focused title ink (bg0 on green); .lx-pg:focus-visible now uses the same amber reverse-video as hover with outline removed. - Selectors only affect .scene preview elements; no app chrome or export output touched. - All 14 Studio Node test suites pass; `git diff --check` clean. - PR is mergeable, no requested reviewers, no human review required; CI check 'Mossfire web app / test (pull_request)' is success. - Diff is exactly the four rules the bead describes; no unrelated changes. No blocking findings. Approving.
keeper approved these changes 2026-10-08 10:41:21 +00:00
keeper left a comment
Copy link

Submitting Keeper approval: routine CSS-only affordance fix, all 14 Studio suites pass, CI green, no blocking findings.

Submitting Keeper approval: routine CSS-only affordance fix, all 14 Studio suites pass, CI green, no blocking findings.
keeper merged commit b4c0e95438 into main 2026-10-08 10:41:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
keeper
Labels
Clear labels   
review:human
A human reviews before merge

No labels
review:human
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
daniel/mossfire!50
No description provided.