[work-hxs5] fix(studio): the register flip fires from the palette's Base field #70

Merged
eden merged 1 commit from work-hxs5-studio-the-register-flip-does-not-fire into main 2026-10-10 21:55:45 +00:00
Owner

The flip only listened to the colour picker's hex input. The palette list has an editable hex field per slot, and that is where a person types a hex: right there, labelled Base. Typing #101713 into it changed the colour and nothing else — no flip, no toast. Reported by Daniel, reproduced, fixed.

Changes

  • the palette's Base hex field and its change handler now go through the same door as the picker's, so every field a person can enter a Base colour in works
  • a register view names itself in the scene bar while it is up — ✳ Mossfire Codex · a view — and clears when the live theme paints. The colours alone read as no change when the swap is entered from the Base slot, because the background is that same colour in both views
  • the publish step stamps asset URLs with the commit. The site serves cache-control: max-age=60, stale-while-revalidate=3600 and nothing versioned the files, so a browser could run an app.js older than the page it came with

Verified

  • full suite green; build_data.py leaves studio/data with no diff
  • driven in a browser: typing #101713 into the palette's Base field now flips the scene to #101713 / #b9d895, shows the bar mark and the toast, then returns and clears the mark; the picker path still works, including the same answer when the theme already is that register
  • register.test.js covers the view flag through the paint path and the bar mark (added, not stacked, cleared, safe with no bar)

Bead: work-hxs5

The flip only listened to the colour picker's hex input. The palette list has an editable hex field per slot, and that is where a person types a hex: right there, labelled Base. Typing `#101713` into it changed the colour and nothing else — no flip, no toast. Reported by Daniel, reproduced, fixed. **Changes** - the palette's Base hex field and its `change` handler now go through the same door as the picker's, so every field a person can enter a Base colour in works - a register view names itself in the scene bar while it is up — `✳ Mossfire Codex · a view` — and clears when the live theme paints. The colours alone read as no change when the swap is entered from the Base slot, because the background is that same colour in both views - the publish step stamps asset URLs with the commit. The site serves `cache-control: max-age=60, stale-while-revalidate=3600` and nothing versioned the files, so a browser could run an `app.js` older than the page it came with **Verified** - full suite green; `build_data.py` leaves `studio/data` with no diff - driven in a browser: typing `#101713` into the palette's Base field now flips the scene to `#101713 / #b9d895`, shows the bar mark and the toast, then returns and clears the mark; the picker path still works, including the `same` answer when the theme already is that register - `register.test.js` covers the view flag through the paint path and the bar mark (added, not stacked, cleared, safe with no bar) Bead: work-hxs5
fix(studio): the register flip fires from the palette's Base field
All checks were successful
Mossfire web app / test (pull_request) Successful in 41s
Mossfire web app / publish (tema.uhyre.dk, global) (pull_request) Has been skipped
Mossfire web app / publish (theme.home.dpis.dk, home) (pull_request) Has been skipped
954afdb572
The flip (work-7ygz) only listened to the colour picker's hex input. The
palette list has an editable hex field per slot, and that is where a person
types a hex: right there, labelled Base. Typing #101713 into it changed the
colour and nothing else — no flip, no toast.

- the palette's Base hex field and its change handler now go through the same
  door as the picker's, so every field a person can enter a Base colour in works
- a register view names itself in the scene bar while it is up
  ("✳ Mossfire Codex · a view") and clears when the live theme paints. The
  colours alone read as no change when the swap is entered from the Base slot:
  the background is that same colour in both views
- the publish step stamps asset URLs with the commit. The site serves
  cache-control max-age=60, stale-while-revalidate=3600 and nothing else
  versioned the files, so a browser could run an app.js older than its page.
  git-pages ignores the query string (verified 200 with one on both hosts)

Tests: register.test.js covers the view flag through the paint path and the bar
mark — added, not stacked, cleared, and safe with no bar.

Bead: work-hxs5
eden merged commit b15729a117 into main 2026-10-10 21:55:45 +00:00
eden deleted branch work-hxs5-studio-the-register-flip-does-not-fire 2026-10-10 21:55:45 +00:00
Sign in to join this conversation.
No reviewers
No labels
review:human
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ember/mossfire!70
No description provided.