[work-hxs5] fix(studio): the register flip fires from the palette's Base field #70
No reviewers
Labels
No labels
review:human
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ember/mossfire!70
Loading…
Reference in a new issue
No description provided.
Delete branch "work-hxs5-studio-the-register-flip-does-not-fire"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The flip only listened to the colour picker's hex input. The palette list has an editable hex field per slot, and that is where a person types a hex: right there, labelled Base. Typing
#101713into it changed the colour and nothing else — no flip, no toast. Reported by Daniel, reproduced, fixed.Changes
changehandler now go through the same door as the picker's, so every field a person can enter a Base colour in works✳ Mossfire Codex · a view— and clears when the live theme paints. The colours alone read as no change when the swap is entered from the Base slot, because the background is that same colour in both viewscache-control: max-age=60, stale-while-revalidate=3600and nothing versioned the files, so a browser could run anapp.jsolder than the page it came withVerified
build_data.pyleavesstudio/datawith no diff#101713into the palette's Base field now flips the scene to#101713 / #b9d895, shows the bar mark and the toast, then returns and clears the mark; the picker path still works, including thesameanswer when the theme already is that registerregister.test.jscovers the view flag through the paint path and the bar mark (added, not stacked, cleared, safe with no bar)Bead: work-hxs5